Effective Java! Use Instance Fields Instead of Ordinals

Effective Java Review (90 Part Series)

There are times that there is a natural ordering and ordinals that could be assigned to our different enums. For example consider the following:

public enum Ensemble {
  SOLO, DUET, TRIO, QUARTET, QUINTET, SEXTET, SEPTET, OCTET, NONTET, DECTET; 

  public int numberOfMusicians( return ordinal() + 1; );
}

Enter fullscreen mode Exit fullscreen mode

Using the ordinal built-in function may initially seem like a good idea as the ordinals follow the correct number that should be returned from our numberOfMusicians function. The problem lies in the maintenance of the enum. The ordering of the values in the enum are tied to their value. This can cause problems for if we want two values to return the same value or if we want to skip a value. For example consider a double quartet which should return 8 from the numberOfMusicians function. However an ordinal can only be connected to one value and OCTET is already connected with that ordinal. Also consider if we wanted to make a value for triple quartet which should return a 12 from the numberOfMusicians function. However ordinals go in order and the last value we have would match up with 11 and not 12. So we either need to make a useless value to fill up space or we can’t do it.

So what we should reach for instead is using instance variables. Using this method we get way more flexibility without giving up much conciseness. Let’s take a look at how this would look.

public enum Ensemble {
  SOLO(1), DUET(2), TRIO(3), QUARTET(4), QUINTET(5), SEXTET(6), SEPTET(7), OCTET(8), DOUBLE_QUARTET(8), NONTET(9), DECTET(10), TRIPLE_QUARTET(12); 

  private final int numberOfMusicians;

  public Ensemble(int numberOfMusicians) {
    this.numberOfMusicisians = numberOfMusicians;
  }

  public int numberOfMusicians( return numberOfMusicians; );
}

Enter fullscreen mode Exit fullscreen mode

In this new and improved version we no longer use the ordinal function and instead use the instance fields. This has given the flexibility to easily add the double and triple quartet ensemble values.

So what good is the ordinal function if we basically are told never to use it. Well the documentation itself says: “Most programmers will have no use for this method. It is designed for use by general-purpose enum-based data structures such as EnumSet and EnumMap“. Unless you are writing code like that you don’t need to worry about this function.

Effective Java Review (90 Part Series)

原文链接：Effective Java! Use Instance Fields Instead of Ordinals

文章版权声明 1、本网站名称：拾光赋
2、本站永久网址：https://www.blogs.ink
3、本网站的文章部分内容可能来源于网络，仅供大家学习与参考，如有侵权，请联系站长QQ：805375623进行删除处理。
4、本站一切资源不代表本站立场，并不代表本站赞同其观点和对其真实性负责。
5、本站一律禁止以任何方式发布或转载任何违法的相关信息，访客发现请向站长举报
6、本站资源大多存储在云盘，如发现链接失效，请联系我们我们会第一时间更新。

THE END